Add x-ci-accept-failures for taglib - #30540
Merged
Merged
Conversation
Kakadu
marked this pull request as draft
August 22, 2026 12:49
Kakadu
force-pushed
the
taglib-constraint
branch
2 times, most recently
from
August 23, 2026 07:43
c92bc4f to
fca6add
Compare
An error was: > (cd _build/default/src && /usr/bin/gcc -fPIC -I/usr/include/taglib -g -I /home/opam/.opam/4.14/lib/ocaml -o taglib_stubs.o -c taglib_stubs.cc) taglib_stubs.cc: In function 'value caml_taglib_file_new(value, value)': taglib_stubs.cc:231:18: error: 'create' is not a member of 'TagLib::FileRef' 231 | f = FileRef::create(filename); this means that version of depext is too new Signed-off-by: Kakadu <kakadu.hafanana@gmail.com>
Kakadu
force-pushed
the
taglib-constraint
branch
from
August 23, 2026 09:18
162c423 to
f37bbe9
Compare
Kakadu
marked this pull request as ready for review
August 23, 2026 09:39
jmid
reviewed
Aug 25, 2026
| ["taglib-dev" "zlib-dev"] {os-family = "alpine"} | ||
| ["libtag-devel"] {os-family = "suse" | os-family = "opensuse"} | ||
| ["libtag-devel"] {os-family = "suse" | os-family = "opensuse" | os-distribution = "cygwin" } | ||
| ["mingw-w64-x86_64-taglib"] {os = "win32" & os-distribution = "msys2"} |
Member
There was a problem hiding this comment.
Thanks!
I can see this includes more than indicated by the PR title.
For MinGW (either MSys2 or Cygwin) we are using a skeleton/template initiated by @dra27 involving separate conf-mingw* packages, started in #26072.
The latest skeleton clean-up is #29795.
I would prefer to mimic that layout for uniformity 🙏
(it is also OK to leave the Windows support changes out - I know it is a bit of work)
Contributor
Author
There was a problem hiding this comment.
I commented out these depexts.
Signed-off-by: Kakadu <kakadu.hafanana@gmail.com>
Kakadu
force-pushed
the
taglib-constraint
branch
from
August 25, 2026 20:20
fb371f4 to
fa1a134
Compare
jmid
reviewed
Aug 27, 2026
| ] | ||
|
|
||
| # Repository has been archived on Jan 14, 2025. | ||
| x-maintenance-intent: [ "(none)" ] |
Member
There was a problem hiding this comment.
I can confirm this. The front page README even says:
⚠️ Deprecation Warning!⚠️
This package is not currently maintained. [...]
so I believe it is warrented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On check.ci.ocaml.org the package is red for ALL compilers. There reason is that in modern distribution the depext C library is too new. The repo is archived, so I marked it as not maintained despite the fact that on Ubuntu 24.04 it should compile fine.