[CLEANUP] Move config/ into seagliderOG1/#74
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR moves configuration files from the config/ directory into the seagliderOG1/ package directory to ensure they are properly packaged and distributed with the library.
- Relocates YAML configuration files to
seagliderOG1/config/ - Updates path resolution in
vocabularies.pyto find configs in the new location - Updates
pyproject.tomlto include the config files in the package distribution
Reviewed Changes
Copilot reviewed 18 out of 26 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| seagliderOG1/vocabularies.py | Updates config directory path from parent to package directory |
| pyproject.toml | Adds package-data configuration to include YAML files |
| Multiple .py files | Standardizes docstring formatting from multi-line to single-line style |
| Multiple .ipynb files | Removes unused imports |
| Documentation files | Updates references to new config directory location |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The
config/directory with the*.yamlfiles wasn't shipping with the package.Here, we move it into the
seagliderOG1/directory and update thepyproject.toml.Checklist:
pytestto check that all tests pass.pre-commit run --all-filesto lint and format the code.Related Issues / Pull Requests:
Link any related issues, pull requests, or discussions: