Skip to content

[FEAT][TEST] Adding relevant variables for flight model#88

Merged
tillmrtz merged 3 commits into
ocean-uhh:mainfrom
tillmrtz:issue87
Apr 8, 2026
Merged

[FEAT][TEST] Adding relevant variables for flight model#88
tillmrtz merged 3 commits into
ocean-uhh:mainfrom
tillmrtz:issue87

Conversation

@tillmrtz

@tillmrtz tillmrtz commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

This pull request resolves #87

Description:

  • In order to run the flight model, important variables like C_VBD, mass and volmax of the glider are needed
  • Two functions were added that extract the variables form a list of potential variables and adds them to the OG1 dataset

Checklist:

  • I have followed the coding conventions.
  • I have updated or added tests to cover my changes.
  • I have updated the documentation if needed.
  • I have run pytest to check that all tests pass.
  • I have run pre-commit run --all-files to lint and format the code.

Link any related issues, pull requests, or discussions:

@mari-lage mari-lage left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@mari-lage mari-lage left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it should work

@mari-lage mari-lage left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this works now...

@tillmrtz tillmrtz merged commit 5387934 into ocean-uhh:main Apr 8, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add glider metadata needed for flight model in OG1 format

2 participants