Skip to content

Fix working_dir handling for os.process_start() on linux and posix #7373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BunterSchatten wants to merge 2 commits into
base: master
Choose a base branch
from
+102 −63
Open

Fix working_dir handling for os.process_start() on linux and posix #7373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b015b3
correctly handle working_dir for _process_start() on linux
BunterSchatten Aug 13, 2026
8e33941
correctly handle working_dir for _process_start() on posix
BunterSchatten Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 48 additions & 27 deletions core/os/process_linux.odin
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,57 +409,78 @@ _process_start :: proc(desc: Process_Desc) -> (process: Process, err: Error) {
return process, .Invalid_Command
}

dir_fd := linux.AT_FDCWD
work_dir_fd := linux.AT_FDCWD
errno: linux.Errno
if desc.working_dir != "" {
dir_cstr := clone_to_cstring(desc.working_dir, temp_allocator) or_return
if dir_fd, errno = linux.open(dir_cstr, _OPENDIR_FLAGS); errno != .NONE {
if work_dir_fd, errno = linux.open(dir_cstr, _OPENDIR_FLAGS); errno != .NONE {
return process, _get_platform_error(errno)
}
}
defer if desc.working_dir != "" {
linux.close(dir_fd)
linux.close(work_dir_fd)
}

// search PATH if just a plain name is provided
exe_path: cstring
executable_name := desc.command[0]
if strings.index_byte(executable_name, '/') < 0 {
path_env := get_env("PATH", temp_allocator)
path_dirs := split_path_list(path_env, temp_allocator) or_return

exe_builder := strings.builder_make(temp_allocator) or_return
if is_absolute_path(executable_name) {
exe_path = clone_to_cstring(executable_name, temp_allocator) or_return
if linux.access(exe_path, linux.X_OK) != .NONE {
return process, .Not_Exist
}

} else {
found: bool
for dir in path_dirs {
strings.builder_reset(&exe_builder)
strings.write_string(&exe_builder, dir)
strings.write_byte(&exe_builder, '/')
strings.write_string(&exe_builder, executable_name)
cur_work_dir: string
exe_builder := strings.builder_make(temp_allocator) or_return

exe_path = strings.to_cstring(&exe_builder) or_return
stat: linux.Statx
if linux.statx(linux.AT_FDCWD, exe_path, {}, {.TYPE, .MODE}, &stat) == .NONE && .IFREG in stat.mode && .IXUSR in stat.mode {
found = true
break
write_cwd :: proc(b: ^strings.Builder, cwd: ^string, allocator: runtime.Allocator) -> (err: Error) {
if cwd^ == "" {
cwd^ = get_working_directory(allocator) or_return
}
strings.write_string(b, cwd^)
if len(cwd) > 0 && !is_path_separator(cwd[len(cwd) - 1]) {
strings.write_byte(b, '/')
}
return
}

// search PATH if just a plain name is provided
if strings.index_byte(executable_name, '/') < 0 {
path_env := get_env("PATH", temp_allocator)
path_dirs := split_path_list(path_env, temp_allocator) or_return

for dir in path_dirs {
strings.builder_reset(&exe_builder)

if !is_absolute_path(dir) {
write_cwd(&exe_builder, &cur_work_dir, temp_allocator) or_return
}

strings.write_string(&exe_builder, dir)
strings.write_byte(&exe_builder, '/')
strings.write_string(&exe_builder, executable_name)

exe_path = strings.to_cstring(&exe_builder) or_return
stat: linux.Statx
if linux.statx(linux.AT_FDCWD, exe_path, {}, {.TYPE, .MODE}, &stat) == .NONE && .IFREG in stat.mode && .IXUSR in stat.mode {
found = true
break
}
}
}
if !found {
// check in cwd to match windows behavior
strings.builder_reset(&exe_builder)
strings.write_string(&exe_builder, "./")
write_cwd(&exe_builder, &cur_work_dir, temp_allocator) or_return
strings.write_string(&exe_builder, executable_name)

exe_path = strings.to_cstring(&exe_builder) or_return
if linux.access(exe_path, linux.X_OK) != .NONE {
return process, .Not_Exist
}
}
} else {
exe_path = clone_to_cstring(executable_name, temp_allocator) or_return
if linux.access(exe_path, linux.X_OK) != .NONE {
return process, .Not_Exist
}
}

// args and environment need to be a list of cstrings
Expand Down Expand Up @@ -567,13 +588,13 @@ _process_start :: proc(desc: Process_Desc) -> (process: Process, err: Error) {
if _, errno = linux.dup2(stderr_fd, STDERR); errno != .NONE {
write_errno_to_parent_and_abort(child_pipe_fds[WRITE], errno)
}
if dir_fd != linux.AT_FDCWD {
if errno = linux.fchdir(dir_fd); errno != .NONE {
if work_dir_fd != linux.AT_FDCWD {
if errno = linux.fchdir(work_dir_fd); errno != .NONE {
write_errno_to_parent_and_abort(child_pipe_fds[WRITE], errno)
}
}

errno = linux.execveat(dir_fd, exe_path, &cargs[0], env)
errno = linux.execve(exe_path, &cargs[0], env)
assert(errno != nil)
write_errno_to_parent_and_abort(child_pipe_fds[WRITE], errno)
}
Expand Down
90 changes: 54 additions & 36 deletions core/os/process_posix.odin
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,57 +50,75 @@ _process_start :: proc(desc: Process_Desc) -> (process: Process, err: Error) {

temp_allocator := TEMP_ALLOCATOR_GUARD({})

// search PATH if just a plain name is provided.
exe_builder := strings.builder_make(temp_allocator)
exe_name := desc.command[0]
if strings.index_byte(exe_name, '/') < 0 {
path_env := get_env("PATH", temp_allocator)
path_dirs := split_path_list(path_env, temp_allocator) or_return
exe_name := desc.command[0]
exe_cstring: cstring

if is_absolute_path(exe_name) {
exe_cstring = strings.clone_to_cstring(exe_name, temp_allocator) or_return

if exe_fd := posix.open(exe_cstring, {.CLOEXEC, .EXEC}); exe_fd == -1 {
err = .Not_Exist
return
} else {
posix.close(exe_fd)
}

} else {
found: bool
for dir in path_dirs {
strings.builder_reset(&exe_builder)
strings.write_string(&exe_builder, dir)
strings.write_byte(&exe_builder, '/')
strings.write_string(&exe_builder, exe_name)
cur_work_dir: string
exe_builder := strings.builder_make(temp_allocator) or_return

if exe_fd := posix.open(strings.to_cstring(&exe_builder) or_return, {.CLOEXEC, .EXEC}); exe_fd == -1 {
continue
} else {
posix.close(exe_fd)
found = true
break
write_cwd :: proc(b: ^strings.Builder, cwd: ^string, allocator: runtime.Allocator) -> (err: Error) {
if cwd^ == "" {
cwd^ = get_working_directory(allocator) or_return
}
strings.write_string(b, cwd^)
if len(cwd) > 0 && !is_path_separator(cwd[len(cwd) - 1]) {
strings.write_byte(b, '/')
}
return
}

// search PATH if just a plain name is provided.
if strings.index_byte(exe_name, '/') < 0 {
path_env := get_env("PATH", temp_allocator)
path_dirs := split_path_list(path_env, temp_allocator) or_return

for dir in path_dirs {
strings.builder_reset(&exe_builder)

if !is_absolute_path(dir) {
write_cwd(&exe_builder, &cur_work_dir, temp_allocator) or_return
}

strings.write_string(&exe_builder, dir)
strings.write_byte(&exe_builder, '/')
strings.write_string(&exe_builder, exe_name)
exe_cstring = strings.to_cstring(&exe_builder) or_return

if exe_fd := posix.open(exe_cstring, {.CLOEXEC, .EXEC}); exe_fd == -1 {
continue
} else {
posix.close(exe_fd)
found = true
break
}
}
}
if !found {
// check in cwd to match windows behavior
strings.builder_reset(&exe_builder)
strings.write_string(&exe_builder, desc.working_dir)
if len(desc.working_dir) > 0 && desc.working_dir[len(desc.working_dir)-1] != '/' {
strings.write_byte(&exe_builder, '/')
}
strings.write_string(&exe_builder, "./")
write_cwd(&exe_builder, &cur_work_dir, temp_allocator) or_return
strings.write_string(&exe_builder, exe_name)
exe_cstring = strings.to_cstring(&exe_builder) or_return

// "hello/./world" is fine right?

if exe_fd := posix.open(strings.to_cstring(&exe_builder) or_return, {.CLOEXEC, .EXEC}); exe_fd == -1 {
if exe_fd := posix.open(exe_cstring, {.CLOEXEC, .EXEC}); exe_fd == -1 {
err = .Not_Exist
return
} else {
posix.close(exe_fd)
}
}
} else {
strings.builder_reset(&exe_builder)
strings.write_string(&exe_builder, exe_name)

if exe_fd := posix.open(strings.to_cstring(&exe_builder) or_return, {.CLOEXEC, .EXEC}); exe_fd == -1 {
err = .Not_Exist
return
} else {
posix.close(exe_fd)
}
}

cwd: cstring; if desc.working_dir != "" {
Expand Down Expand Up @@ -174,7 +192,7 @@ _process_start :: proc(desc: Process_Desc) -> (process: Process, err: Error) {
if posix.chdir(cwd) != .OK { abort(pipe[WRITE]) }
}

res := posix.execve(strings.to_cstring(&exe_builder) or_return, raw_data(cmd), env)
res := posix.execve(exe_cstring, raw_data(cmd), env)
assert(res == -1)
abort(pipe[WRITE])

Expand Down
Loading