Skip to content

ENH: add random ellipsoid phantom#1315

Open
kohr-h wants to merge 1 commit into
odlgroup:masterfrom
kohr-h:random_ellipsoids
Open

ENH: add random ellipsoid phantom#1315
kohr-h wants to merge 1 commit into
odlgroup:masterfrom
kohr-h:random_ellipsoids

Conversation

@kohr-h

@kohr-h kohr-h commented Mar 23, 2018

Copy link
Copy Markdown
Member

This might be useful.

@adler-j adler-j left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall very good, but since this is actually somewhat speed critical (people would use it in e.g. ML) I think we need to be more careful. Specifically we should try to do away with all the "while" loops, especially globally. If we cannot do that, at least move them locally.

@kohr-h

kohr-h commented Mar 31, 2018

Copy link
Copy Markdown
Member Author

I admit this is the lazy implementation. I'll make one that checks overlap with the coordinates only.

@kohr-h

kohr-h commented Apr 26, 2018

Copy link
Copy Markdown
Member Author

I've done some work on this a while ago, but it turned out that it's nontrivial to efficiently determine whether an ellipsoid intersects another one, apart from trivial situations. I've got one pending idea that's not implemented yet, which is to transform the coordinates such that the "query ellipsoid" becomes a ball -- this reduces the problem to determining the distance of an ellipsoid to the origin.

Other suggestions are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants