[FIX] util.move_model: modify email_template only if model column exists#398
Closed
MrRose765 wants to merge 1 commit intoodoo:masterfrom
Closed
[FIX] util.move_model: modify email_template only if model column exists#398MrRose765 wants to merge 1 commit intoodoo:masterfrom
MrRose765 wants to merge 1 commit intoodoo:masterfrom
Conversation
Contributor
|
|
aj-fuentes
reviewed
Mar 26, 2026
MrRose765
force-pushed
the
master-fix_move_model_mail_template-cymo
branch
from
652d65a to
f7fa7cd
Compare
Contributor
|
|
Contributor
|
upgradeci retry with always only account crm im_chat in 9.0 master |
aj-fuentes
approved these changes
Mar 27, 2026
Contributor
Author
|
@KangOl CI fail does not seem related. Does it look good to merge ? :) |
KangOl
reviewed
Apr 10, 2026
MrRose765
force-pushed
the
master-fix_move_model_mail_template-cymo
branch
from
f7fa7cd to
fc5b908
Compare
MrRose765
changed the title
In [move_model], we were always updating the `email.template` model, even if the model is replaced by `mail.template` since OpenERP 9.0. The problem is that it prevents users from creating a custom `email.template` model even if it is not used in standard since version 8.0. Related issue : - [PR-specific](odoo/upgrade-specific#20818) [move_model]: https://github.com/odoo/upgrade-util/blob/f97b7a28ef62fe4a7b0417854a904d132adc9882/src/util/modules.py#L1271
MrRose765
force-pushed
the
master-fix_move_model_mail_template-cymo
branch
from
fc5b908 to
e610ab5
Compare
KangOl
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In move_model, we were always updating the
email.templatemodel,even if the model is replaced by
mail.templatesince OpenERP 9.0.The problem is that it prevents users from creating a custom
email.templatemodeleven if it is not used in standard since version 8.0.
Related issue :