Add bracket percentile to player benchmarks - #2979
Merged
Merged
Conversation
howardchung
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
pct_bracketfield next topctin the match players' benchmarks: the same percentile computed against only the matches in this match's rank bracket, using the bracket zsets from #2972. The bracket is derived from the players' average rank with getMatchRankTier, same as the write side in counts.ts. Skipped for turbo (no bracket keys) and when the bracket zset is empty, so the field is additive and consumers that don't know about it see no change.odota/web#3373 uses it to add a line to the benchmark tooltips: "Equal or higher than X% at this match's average rank".
Note: branched on top of #2978 since both touch the same lines of getPlayerBenchmarks (the deaths_per_min inversion applies to the bracket percentile too).