fix(rag): let runtime adopt the recovered document store - #5959
Draft
RaresKeY wants to merge 1 commit into
Draft
Conversation
RaresKeY
force-pushed
the
fix/rag-live-manager-recovery
branch
from
August 9, 2026 00:08
68aa0cc to
12da466
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow the runtime to adopt a recovered document store through a shared
PersonalDocsManagerso chat, personal-document routes, indexing/removal, and agent document tools use the same live RAG instance after delayed backend recovery. This prevents startup-time fallback state from remaining permanently disconnected after the document store becomes available.Publication must retain a live delayed-Chroma and end-to-end gate: the automated recovery tests pass, but recovery from an unavailable-at-startup Chroma instance still needs to be demonstrated through chat and agent document operations in the running application.
Target branch
dev, notmain. All PRs land indev;mainis curated by the maintainer at each release. If your PR is onmainby accident, click "Edit" on this PR and change the base.Linked Issue
Fixes #5948
Part of #4377
Type of Change
Checklist
devdocker compose uporuvicorn app:app) and verified the change works end-to-end. Type-checks and unit tests are not enough.The live delayed-Chroma startup/recovery and end-to-end chat/agent scenarios remain required before claiming application-level validation.
How to Test
python -m pytest -q tests/test_rag_live_manager_recovery.py tests/test_rag_keyword_fallback_owner.py tests/test_rag_manager_owner_compat.py tests/test_rag_remove_directory_scope.py tests/test_rag_search_signature.py tests/test_personal_docs_state_store.py; the validated head reports 12 passing tests and one warning.Visual / UI changes — REQUIRED if you touched anything that renders
Anything that changes what the UI looks like — buttons, icons, padding, colors, fonts, spacing, layout, CSS, HTML, SVG, or any
static/js/module that draws to the DOM — needs all of the following. PRs that change rendering without these WILL be closed.N/A — no rendered UI files are changed; the remaining end-to-end gate concerns runtime behavior.
--red,--fg,--bg,--card,--border, etc.) — do not introduce new color values, font sizes, or spacing units.static/index.html) or plain text.Fira Code) for primary UI text. Don't override.Screenshots / clips
N/A — no rendered UI files changed.