fix(docs): map live VectorRAG result shapes - #5960
Draft
RaresKeY wants to merge 1 commit into
Draft
Conversation
RaresKeY
force-pushed
the
fix/docs-vectorrag-contract
branch
from
August 9, 2026 00:08
d196405 to
f3d911b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Map the live
VectorRAGquery and indexing result shapes into the existingDocsServicecontract. Query results now read canonical document text, similarity, and source metadata while retaining legacy aliases, malformed rows are skipped safely, and indexing reports use the canonical indexed/failed counts. This updates the service facade without adding a new runtime route.Target branch
dev, notmain. All PRs land indev;mainis curated by the maintainer at each release. If your PR is onmainby accident, click "Edit" on this PR and change the base.Linked Issue
Fixes #5949
Part of #4377
Related: #5794
Type of Change
Checklist
devdocker compose uporuvicorn app:app) and verified the change works end-to-end. Type-checks and unit tests are not enough.The facade mapping is covered by focused tests, but no live Chroma-backed application consumer has been exercised.
How to Test
python -m pytest -q tests/test_docs_query_nondict_rows.py tests/test_rag_search_signature.py tests/test_rag_manager_owner_compat.py tests/test_rag_keyword_fallback_owner.py; the validated head reports 6 passing tests and one warning.DocsServicecanonical query rows containingdocument,similarity, andmetadata.source, and verify the returned service result preserves those values.indexed_countandfailed_count, and verify the service report uses those counters.Visual / UI changes — REQUIRED if you touched anything that renders
Anything that changes what the UI looks like — buttons, icons, padding, colors, fonts, spacing, layout, CSS, HTML, SVG, or any
static/js/module that draws to the DOM — needs all of the following. PRs that change rendering without these WILL be closed.N/A — no rendered UI files or routes are changed.
--red,--fg,--bg,--card,--border, etc.) — do not introduce new color values, font sizes, or spacing units.static/index.html) or plain text.Fira Code) for primary UI text. Don't override.Screenshots / clips
N/A — no rendered UI files changed.