Revise storage parameters and add parent class

[uvchik]

There are now two values for c-rate and efficiency. If you just set the crate for charging the c-rate for discharging will be the same.

The c-rate is renamed in thermal storage to theoretical_time_charge which is not beatiful but more common for thermal storages.

[codecov]

❌ 29 Tests Failed:

Tests completed	Failed	Passed	Skipped
131	29	102	3

View the top 3 failed test(s) by shortest run time

tests.postprocessing.test_graph.TestCapacitiesGraph::test_capacities_graph_basic

Stack Traces | 0.007s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestCapacitiesGraph::test_capacities_graph_empty_nodes

Stack Traces | 0.007s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestCapacitiesGraph::test_capacities_graph_layout

Stack Traces | 0.007s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestCapacitiesGraph::test_capacities_graph_marker_style

Stack Traces | 0.007s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestCapacitiesGraph::test_capacities_graph_no_optimized_capacity

Stack Traces | 0.007s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestCapacitiesGraph::test_capacities_graph_values

Stack Traces | 0.007s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestEdgeCases::test_capacities_graph_all_zeros

Stack Traces | 0.007s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestIntegration::test_capacities_full_workflow

Stack Traces | 0.007s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestIntegration::test_sankey_full_workflow

Stack Traces | 0.007s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestSankey::test_sankey_hover_template_with_row

Stack Traces | 0.007s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestSankey::test_sankey_hover_template_without_row

Stack Traces | 0.007s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestSankey::test_sankey_invalid_aggregation

Stack Traces | 0.007s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestSankey::test_sankey_max_aggregation

Stack Traces | 0.007s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestSankey::test_sankey_with_energy_system

Stack Traces | 0.007s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestSankey::test_sankey_with_row_index_int

Stack Traces | 0.007s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestSankey::test_sankey_with_row_index_label

Stack Traces | 0.007s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestSankeyParametrized::test_sankey_all_aggregations[max]

Stack Traces | 0.007s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestSankeyParametrized::test_sankey_all_aggregations[sum]

Stack Traces | 0.007s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestSankeyParametrized::test_sankey_different_rows[0]

Stack Traces | 0.007s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestSankeyParametrized::test_sankey_different_rows[10]

Stack Traces | 0.007s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestSankeyParametrized::test_sankey_different_rows[15]

Stack Traces | 0.007s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestSankeyParametrized::test_sankey_different_rows[20]

Stack Traces | 0.007s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graphs::test_graph_capacities

Stack Traces | 0.007s run time

tests/postprocessing/test_graphs.py:116: in test_graph_capacities
    res, es = simple_script()
              ^^^^^^^^^^^^^^^
tests/postprocessing/test_graphs.py:85: in simple_script
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestSankey::test_sankey_mean_aggregation

Stack Traces | 0.008s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestSankeyParametrized::test_sankey_all_aggregations[mean]

Stack Traces | 0.008s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestSankey::test_sankey_basic_sum_aggregation

Stack Traces | 0.009s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.postprocessing.test_graph.TestSankeyParametrized::test_sankey_different_rows[5]

Stack Traces | 0.009s run time

tests/postprocessing/test_graph.py:93: in sample_energy_system
    ElectricalStorage(
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'crate'

tests.test_datapackage::test_simple_datapackage

Stack Traces | 0.502s run time

tests/test_datapackage.py:17: in test_simple_datapackage
    energy_system = es.create_energy_system_from_dp(path)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.../eesyplan/datapackage/energy_system.py:27: in create_energy_system_from_dp
    es = EnergySystem.from_datapackage(
.../hostedtoolcache/Python/3.13.13........./x64/lib/python3.13.../datapackage/datapackage/reading.py:627: in deserialize_energy_system
    read_facade(
.../hostedtoolcache/Python/3.13.13........./x64/lib/python3.13.../datapackage/datapackage/reading.py:112: in read_facade
    instance = create(mapping, facade, facade)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.../hostedtoolcache/Python/3.13.13........./x64/lib/python3.13.../datapackage/datapackage/reading.py:359: in create
    instance = clsi(**init)
               ^^^^^^^^^^^^
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'efficiency'

tests.postprocessing.test_graphs::test_sankey_diagram

Stack Traces | 0.517s run time

tests/postprocessing/test_graphs.py:126: in test_sankey_diagram
    energy_system = es.create_energy_system_from_dp(path)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.../eesyplan/datapackage/energy_system.py:27: in create_energy_system_from_dp
    es = EnergySystem.from_datapackage(
.../hostedtoolcache/Python/3.13.13........./x64/lib/python3.13.../datapackage/datapackage/reading.py:627: in deserialize_energy_system
    read_facade(
.../hostedtoolcache/Python/3.13.13........./x64/lib/python3.13.../datapackage/datapackage/reading.py:112: in read_facade
    instance = create(mapping, facade, facade)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.../hostedtoolcache/Python/3.13.13........./x64/lib/python3.13.../datapackage/datapackage/reading.py:359: in create
    instance = clsi(**init)
               ^^^^^^^^^^^^
E   TypeError: ElectricalStorage.__init__() got an unexpected keyword argument 'efficiency'

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[uvchik]

The parameter changed. Therefore, the names in the datapackages must be adapted, too. But first, let us discuss the changes.