Fix garage refuel handling of bad/old state data - #3913
Open
jaj22 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this.
What have you changed and why?
If you put a fuel vehicle into the garage with ACE loaded, it'll write the vanilla fuel cargo as -1. This was then used for calculations of available fuel, causing ACE + non-ACE garaged tankers to report 0 fuel total. It also broke the actual refuel function. Fixed with a scattering of
0 max.At some point the garage was capable of writing nil as the ACE fuel cargo. If then used with ACE, the refuel function would do its crackheaded infinite loop and then fail to refuel anything. Fixed with a nil check.
Also sanitized some related code. Should really rework the refuel function to be less dangerous but maybe later.
Please specify which Issue this PR Resolves.
closes #XXXX
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?