Add uncontested-area Loot to Crate range option - #3946
Open
gabriel-quina wants to merge 2 commits into
Open
Conversation
Author
|
Updated the PR description and marked this as ready for review. The player feedback To-Do has been implemented: when the extended Loot to Crate range is actually used, the final hint now shows an extra message indicating that the extended range was applied. It does not show a separate message when the extended range is blocked, to avoid exposing nearby enemy presence. |
gabriel-quina
marked this pull request as ready for review
June 1, 2026 03:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Change / Enhancement
What does this PR change and why?
Adds an optional uncontested-area range for the existing Loot to Crate functionality.
The current Loot to Crate behavior is preserved by default. When the new setting is disabled, the existing
LootToCrateRadiusis used as before.When enabled, the existing loot collection logic can use an extended range only if there are no living fight-capable enemy units near the crate. Enemies are checked within twice the selected range, so a 400m collection range requires the surrounding 800m area to be clear.
A feedback message is shown when the extended Loot to Crate range is actually used, so players can tell when the new behavior was applied without exposing whether nearby enemies blocked it.
The intent is to reduce repetitive post-combat cleanup for solo and small-group players without changing behavior while an area is still contested.
Testing
Local checks performed:
git diff --checkFunctional validation:
Discussion
The enemy check radius is currently calculated as twice the selected uncontested loot range.
This keeps the setting simple for players and prevents unsafe combinations such as a very large collection range with a very small enemy check radius. For example, a 400m uncontested collection range requires the surrounding 800m area to be clear.
An alternative would be to expose the enemy check radius as a separate parameter. That would allow more flexibility for different server balance preferences, but would also add another mission parameter and could allow configurations that make the feature easier to exploit.
Feedback welcome on whether the fixed 2x check radius is preferred, or whether a separate configurable check range would be useful.