Support for the Advanced Combat Medicine mod - #3950
Open
DairyProductsz wants to merge 2 commits into
Open
Conversation
Additonal notes: - KAT and ACM should never be both loaded at once, and ACM throws an error when KAT is loaded. But in the case both ACM and KAT are loaded somehow, A3A_hasKAT will be set to false. - Although ACE bandages technically still function in ACM, ACM comes with its own bandage items that are meant to replace the default ACE ones. Based on this, regular ACE bandages are hidden from the arsenal if ACM is loaded. - Like KAT, ACM also comes with blood types & reworked blood bag items, so the aceMedItemsNonKat variable has been renamed to aceDefaultBloodItems.
When ACM is loaded, first-aid "loadouts" for AI units are modified to carry ACM specific items e.g. ACE bandages are replaced with ACM bandages. The ACM first-aid loadouts are pretty much the same as the regular ACE loadouts, with the exception that ACM_IV_16g is provided to any loadout containing saline or blood, because ACM requires an IV/IO item to use saline and blood packets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this.
What have you changed and why?
Advanced Combat Medicine is a mod that extends the ACE medical system, in a somewhat similar manner to KAT.
Like KAT, the most important change for compatibility was modifying
fn_arsenal.sqfandfn_initVarCommon.sqfso that ACM medical items are unlocked in the arsenal, and hiding the default ACE blood bags + painkiller as is done when KAT is loaded. ACM also comes with new bandage items that are intended to be used instead of the default ACE bandages (see note 1.), so I decided to also hide ACE bandages from the arsenal when ACM is loaded.The only other change made is modifications to
fn_ACEpvpReDress.sqf,fn_itemset_medicalSupplies.sqf, andfn_aceModCompat.sqffor AI units to have the correct medical items for ACM. In particular:ACM_ElasticWrapreplacesACE_elasticBandage, andACM_PressureBandagereplaces the rest of the ACE bandages (basic bandage, packing bandage, and quikclot).ACM_IV_16ghas been added to any medical loadouts that contain blood or saline.If these first-aid loadout changes are a bit too much however, a simpler alternative patch for compatibility would be to just unlock ACM items in the arsenal (i.e. keeping the changes made to
fn_arsenal.sqfandfn_initVarCommon.sqf, maybe without hiding ACE bandages so that looting doesn't become messy).Please specify which Issue this PR Resolves.
No existing issue references this.
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?
How can the changes be tested?
Install and load both ACE and Advanced Combat Medicine. If you go to the arsenal, you should see that ACM items are unlocked and that the default ACE blood & bandages are hidden. If you purchase a militiaman and a medic and view their inventory, they should have ACM items as I described earlier. If you manage to kill an enemy rifleman and combat-life-saver, they should also have the appropriate medical items. For my personal testing, I also verified that non-ACE, ACE, and ACE + KAT still gave the correct items.
Other than the above, you could also just test general gameplay and combat. I ran multiple trials using ACM where I bought some friendly AI and attacked a roadblock, and I did not run into any bugs even after healing units (naturally via the medical system to be clear, not with commands or anything).
Notes:
I figure that compatibility for ACM is as simple as just providing the correct items as is done for KAT, but if you'd like to investigate ACM itself further for potential issues, you can view the ACM Github here. The ACM Wiki and ACM Guide may also be helpful resources. Note that Slide 6 in the ACM Guide (from their official Discord) strongly discourages using ACE bandages with ACM.
If it wasn't already clear, KAT and ACM are incompatible with each other. ACM already throws an error if you attempt to start a mission with both ACM and KAT enabled so I don't think Antistasi itself needs to add its own warning for this, but let me know if I need to make further changes to address this.