refactor(tools)!: move /v1/tools route to /v1/admin/tools - #5787
Merged
Conversation
Tools are admin-controlled resources configured at the distribution level, not user-scoped. Move the tools listing endpoint under /v1/admin for consistency with the connectors move in ogx-ai#5659. The Admin protocol now includes list_tools, and AdminImpl delegates to the ToolGroups routing table implementation. BREAKING CHANGE: GET /v1/tools is now served at GET /v1/admin/tools. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
requested review from
bbrowning,
cdoern,
franciscojavierarceo,
mattf and
raghotham
as code owners
May 11, 2026 15:58
cdoern
approved these changes
May 11, 2026
Collaborator
|
if we are moving connectors we need to move this as well, lgtm |
franciscojavierarceo
approved these changes
May 11, 2026
leseb
enabled auto-merge
May 11, 2026 16:04
Contributor
✱ Stainless preview buildsThis PR will update the
|
Signed-off-by: Charlie Doern <cdoern@redhat.com> # Conflicts: # client-sdks/stainless/openapi.yml # docs/static/deprecated-ogx-spec.yaml # docs/static/experimental-ogx-spec.yaml # docs/static/ogx-spec.yaml # docs/static/stainless-ogx-spec.yaml # src/ogx/core/admin.py # src/ogx_api/admin/api.py # src/ogx_api/admin/fastapi_routes.py
Signed-off-by: Charlie Doern <cdoern@redhat.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
added a commit
to leseb/ogx
that referenced
this pull request
May 12, 2026
# What does this PR do? Updates three documentation pages that still referenced the old `/v1/tools` endpoint path after ogx-ai#5787 moved it to `/v1/admin/tools`. Files updated: - `docs/src/pages/index.js` — landing page API grid - `docs/docs/api-overview.mdx` — API reference overview - `docs/docs/building_applications/tools.mdx` — tools guide prose ## Test Plan 1. Run the docs dev server: `cd docs && npm install && npx docusaurus gen-api-docs all && npx docusaurus start` 2. Verify the landing page API grid shows `/v1/admin/tools` 3. Verify `/docs/api-overview` shows `/v1/admin/tools` in the stable section 4. Verify `/docs/building_applications/tools` prose references `/v1/admin/tools` Signed-off-by: Sébastien Han <seb@redhat.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves the
GET /v1/toolsendpoint toGET /v1/admin/tools, following the same pattern as #5659 (connectors → admin). Tools are admin-controlled resources configured at the distribution level, not user-scoped — users don't register or unregister tool groups. The rationale is identical to the connectors move.Pattern followed from #5659:
Adminprotocol gainslist_toolsmethodAdminImpldelegates to theToolGroupsRoutingTableviaself.depsfastapi_routes.pydeleted; route served by the admin router/v1alpha(existing admin endpoints) and/v1(tools) prefixesBREAKING CHANGE:
GET /v1/toolsis removed. UseGET /v1/admin/toolsinstead.Test Plan
api-conformancewhich is expected for breaking changes — therefactor!:commit message signals intentional breakage)uv run pytest tests/unit/core/ --tb=short -q -k "tool or route or admin"— 77 passed