fix(ci): prevent test fixtures from overwriting main server log - #5797
Merged
Conversation
The main server log (server.log) was being deleted and overwritten by test fixtures that start their own server instances (e.g. telemetry tests). This made it impossible to diagnose 500 errors from the main server since the traceback was lost. Rename the main server log to server-main.log so it persists alongside the fixture's server.log. Both are captured by the *.log artifact glob. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Derek Higgins <derekh@redhat.com>
derekhiggins
requested review from
bbrowning,
cdoern,
franciscojavierarceo,
leseb,
mattf and
raghotham
as code owners
May 12, 2026 11:45
leseb
approved these changes
May 12, 2026
leseb
left a comment
leseb
left a comment
Member
There was a problem hiding this comment.
i guess using OGX_LOG_FILE would have solved it too?
Member
|
@Mergifyio backport release-1.0.x |
Contributor
✅ Backports have been createdDetails
|
2 tasks
leseb
pushed a commit
that referenced
this pull request
May 12, 2026
## Summary - Rename main server log from `server.log` to `server-main.log` in `scripts/integration-tests.sh` - Prevents test fixtures (e.g. telemetry tests) that start their own server instances from deleting and overwriting the main server's log - Both files are still captured by the existing `*.log` artifact upload glob Fixes #5796 ## Test plan - [ ] CI integration tests still collect server logs correctly - [ ] Fixture server logs remain separate from main server log Signed-off-by: Derek Higgins <derekh@redhat.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> (cherry picked from commit e97035f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server.logtoserver-main.loginscripts/integration-tests.sh*.logartifact upload globFixes #5796
Test plan