Skip to content

fix(tests): add Bedrock replay recordings - #6166

Merged
cdoern merged 1 commit into
ogx-ai:mainfrom
skamenan7:fix/bedrock-replay-recordings-6016
Jun 23, 2026
Merged

fix(tests): add Bedrock replay recordings#6166
cdoern merged 1 commit into
ogx-ai:mainfrom
skamenan7:fix/bedrock-replay-recordings-6016

Conversation

@skamenan7

Copy link
Copy Markdown
Collaborator

Summary

  • add replay recordings for the two Bedrock streaming chat-completion hashes introduced after the ogx_open_client switch
  • fixes the missing-recording failures from PR chore(ci): change CI to use ogx_open_client #6016 without changing runtime behavior

Test Plan

  • env AWS_BEDROCK_BEARER_TOKEN=replay-mode-dummy-key AWS_DEFAULT_REGION=us-west-2 uv run --no-sync ./scripts/integration-tests.sh --stack-config ci-tests --setup bedrock --suite bedrock --inference-mode replay
  • Result: 6 passed, 6 skipped

Signed-off-by: Sumanth Kamenani <skamenan@redhat.com>

@cdoern cdoern left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do this via the re record mechanism. Otherwise we might see differences. Thanks.

@cdoern

cdoern commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

#6165

@skamenan7

Copy link
Copy Markdown
Collaborator Author

I think we should do this via the re record mechanism. Otherwise we might see differences. Thanks.

I agree. #6165 is the right long-term path because it records the Bedrock inference suite through the normal workflow.

My only concern is timing: #6165 by itself won’t unblock replay CI until the record workflow is run and the generated recordings are committed. #6166 was just the direct replay-file patch for the two missing hashes we saw in CI. If you are going to run the record workflow and commit the generated output, we can close #6166 and use that path instead.

@cdoern

cdoern commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

https://github.com/ogx-ai/ogx/actions/runs/28026902373/job/82956977057 seems the re-record is un-authenticated :(

lets merge this

@cdoern
cdoern added this pull request to the merge queue Jun 23, 2026
Merged via the queue into ogx-ai:main with commit 7f29a57 Jun 23, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants