Skip to content

fix(deps): make OCI dependencies optional on release 0.5 - #6193

Merged
skamenan7 merged 7 commits into
ogx-ai:release-0.5.xfrom
skamenan7:fix/oci-default-deps-release-0.5
Jun 26, 2026
Merged

fix(deps): make OCI dependencies optional on release 0.5#6193
skamenan7 merged 7 commits into
ogx-ai:release-0.5.xfrom
skamenan7:fix/oci-default-deps-release-0.5

Conversation

@skamenan7

@skamenan7 skamenan7 commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove OCI-related packages from default package dependencies on release-0.5.x
  • expose them through the explicit oci extra instead
  • add tests that guard default/starter installs while preserving explicit OCI provider deps

Before / after proof

Built wheel metadata from v0.5.2 before the fix advertised OCI dependencies unconditionally:

Requires-Dist: oracledb>=3.4.1
Requires-Dist: oci>=2.165.0
Requires-Dist: numpy>=2.3.2

Built wheel metadata after this fix advertises them only behind the oci extra:

Provides-Extra: oci
Requires-Dist: numpy>=2.3.2; extra == "oci"
Requires-Dist: oci>=2.165.0; extra == "oci"
Requires-Dist: oracledb>=3.4.1; extra == "oci"

Test plan

  • uv run --locked pytest tests/unit/distribution/test_stack_list_deps.py -q
  • env UV_CACHE_DIR=/tmp/uv-cache-ogx-oci-05 UV_PYTHON_INSTALL_DIR=/tmp/uv-python-ogx-oci-05 uv build --wheel

Signed-off-by: Sumanth Kamenani <skamenan@redhat.com>
Signed-off-by: Sumanth Kamenani <skamenan@redhat.com>
Signed-off-by: Sumanth Kamenani <skamenan@redhat.com>
Signed-off-by: Sumanth Kamenani <skamenan@redhat.com>
Signed-off-by: Sumanth Kamenani <skamenan@redhat.com>
Signed-off-by: Sumanth Kamenani <skamenan@redhat.com>
@mergify

mergify Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be merged. @skamenan7 please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase label Jun 26, 2026
Signed-off-by: Sumanth Kamenani <skamenan@redhat.com>

# Conflicts:
#	.github/workflows/pypi.yml
#	scripts/integration-tests.sh
@mergify mergify Bot removed the needs-rebase label Jun 26, 2026
@skamenan7
skamenan7 marked this pull request as ready for review June 26, 2026 21:55
@skamenan7
skamenan7 merged commit 22a535e into ogx-ai:release-0.5.x Jun 26, 2026
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants