Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,3 @@
# OpenAPI SDK generation and publishing
/client-sdks/openapi/ @ashwinb @leseb @bbrowning
/.github/workflows/openapi-generator-validation.yml @ashwinb @leseb @bbrowning
/.github/workflows/publish-openapi-sdk.yml @ashwinb @leseb @bbrowning
1 change: 0 additions & 1 deletion .github/workflows/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ OGX uses GitHub Actions for Continuous Integration (CI). Below is a table detail
| Pre-commit | [pre-commit.yml](pre-commit.yml) | Run pre-commit checks |
| Prepare release | [prepare-release.yml](prepare-release.yml) | Prepare release |
| Test OGX Build | [providers-build.yml](providers-build.yml) | Test ogx build and list-deps |
| Publish OpenAPI SDK to PyPI | [publish-openapi-sdk.yml](publish-openapi-sdk.yml) | Publish ogx-open-client to PyPI |
| Build, test, and publish packages | [pypi.yml](pypi.yml) | Build, test, and publish packages |
| Integration Tests (Record) | [record-integration-tests.yml](record-integration-tests.yml) | Auto-record missing test recordings for PR |
| vLLM GPU Recording | [record-vllm-gpu-tests.yml](record-vllm-gpu-tests.yml) | GPU recording for gpt-oss:20b (${{ inputs.suite }} suite) |
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/openapi-generator-validation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ jobs:

- name: Generate Python SDK
working-directory: client-sdks/openapi
run: make sdk OPEN=1
run: make sdk OPEN=0

- name: Validate generated SDK
working-directory: client-sdks/openapi
Expand Down Expand Up @@ -217,14 +217,14 @@ jobs:

- name: Install generated SDK
run: |
echo "Reinstalling OpenAPI-generated SDK (ogx_open_client)..."
uv pip uninstall ogx-open-client || true
echo "Reinstalling OpenAPI-generated SDK (ogx_client)..."
uv pip uninstall ogx-client || true

# Install SDK using uv pip
uv pip install -e client-sdks/openapi/sdks/python

echo "Verifying installation..."
uv run python -c "import ogx_open_client; print(f'Installed: {ogx_open_client.__name__}')"
uv run python -c "import ogx_client; print(f'Installed: {ogx_client.__name__}')"

- name: Setup Ollama (for integration tests)
if: runner.os == 'Linux'
Expand All @@ -242,7 +242,7 @@ jobs:
|| echo "::warning::Some integration tests failed - this may indicate SDK compatibility issues"

# Show which SDK is actually being used
uv run python -c "import ogx_open_client; import inspect; print(f'SDK location: {inspect.getfile(ogx_open_client)}')"
uv run python -c "import ogx_client; import inspect; print(f'SDK location: {inspect.getfile(ogx_client)}')"

- name: Summary
if: runner.os == 'Linux'
Expand All @@ -255,5 +255,5 @@ jobs:
echo "✅ Integration tests executed (check logs for results)"
echo ""
echo "**Platform**: ${{ matrix.os }}"
echo "**Package**: ogx_open_client (OpenAPI-generated)"
echo "**Package**: ogx_client (OpenAPI-generated)"
} >> "$GITHUB_STEP_SUMMARY"
176 changes: 0 additions & 176 deletions .github/workflows/publish-openapi-sdk.yml

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove this workflow? Seems duplicative and pypi.yml should be the only place we publish packages from -- per the trusted publishing settings on pypi.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I agree, removed.

This file was deleted.

Loading