-
Notifications
You must be signed in to change notification settings - Fork 5
Implement conformsTo #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FikriMilano
wants to merge
5
commits into
ohs-foundation:main
Choose a base branch
from
FikriMilano:conforms-to
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement conformsTo #109
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
af4baf4
Implement conformsTo
FikriMilano dd0aab5
Fix profile wording in conformsTo documentation
FikriMilano 6483704
Link the R4 spec in conformsTo documentation
FikriMilano e6e3be6
Separate conforming and non-conforming test cases
FikriMilano 699fe19
Merge branch 'main' of github.com:google/kotlin-fhirpath into conform…
FikriMilano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95 changes: 95 additions & 0 deletions
95
fhir-path/src/commonTest/kotlin/dev/ohs/fhir/fhirpath/ConformsToTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| /* | ||
| * Copyright 2026 Open Health Stack Foundation | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package dev.ohs.fhir.fhirpath | ||
|
|
||
| import dev.ohs.fhir.model.r4.Resource | ||
| import kotlin.test.Test | ||
| import kotlin.test.assertEquals | ||
| import kotlin.test.assertFailsWith | ||
| import kotlinx.serialization.json.Json | ||
|
|
||
| private val fhirPathEngine = FhirPathEngine.forR4() | ||
|
|
||
| private val patient: Resource = | ||
| Json { ignoreUnknownKeys = true } | ||
| .decodeFromString("""{"resourceType": "Patient", "name": [{"family": "Chalmers"}]}""") | ||
|
|
||
| class ConformsToTest { | ||
|
|
||
| @Test | ||
| fun `element conforms to its base data type profile`() { | ||
| assertEquals( | ||
| listOf(true), | ||
| fhirPathEngine | ||
| .evaluateExpression( | ||
| "name.first().conformsTo('http://hl7.org/fhir/StructureDefinition/HumanName')", | ||
| patient, | ||
| ) | ||
| .toList(), | ||
| ) | ||
| } | ||
|
|
||
| @Test | ||
| fun `element does not conform to a different data type profile`() { | ||
| assertEquals( | ||
| listOf(false), | ||
| fhirPathEngine | ||
| .evaluateExpression( | ||
| "name.first().conformsTo('http://hl7.org/fhir/StructureDefinition/Address')", | ||
| patient, | ||
| ) | ||
| .toList(), | ||
| ) | ||
| } | ||
|
|
||
| @Test | ||
| fun `unresolvable structure throws`() { | ||
| assertFailsWith<Exception> { | ||
| fhirPathEngine.evaluateExpression( | ||
| "conformsTo('http://hl7.org/fhir/StructureDefinition/NotARealType')", | ||
| patient, | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| fun `structure resolving only to a System type throws`() { | ||
| // `String` is not a FHIR structure definition (FHIR's is lowercase `string`), so it must | ||
| // error rather than fall back to the System type and return false. The input element is a | ||
| // FHIR string, so with the lowercase URL this would return true; the error is about the | ||
| // structure being unresolvable, not about the input. | ||
| assertFailsWith<Exception> { | ||
| fhirPathEngine.evaluateExpression( | ||
| "name.first().family.conformsTo('http://hl7.org/fhir/StructureDefinition/String')", | ||
| patient, | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| fun `empty input returns empty`() { | ||
| assertEquals( | ||
| emptyList(), | ||
| fhirPathEngine | ||
| .evaluateExpression( | ||
| "{}.conformsTo('http://hl7.org/fhir/StructureDefinition/Patient')", | ||
| patient, | ||
| ) | ||
| .toList(), | ||
| ) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.