Implement comparable - #110
Open
FikriMilano wants to merge 1 commit into
Open
Conversation
LZRS
reviewed
Aug 7, 2026
| params.singleOrNull()?.toFhirPathType(fhirPathTypeResolver) as? FhirPathQuantity | ||
| ?: return emptyList() | ||
|
|
||
| val leftUnit = left.toEqualCanonicalized().unit ?: return emptyList() |
Contributor
There was a problem hiding this comment.
Should it return emptyList() or listOf(false)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the
comparable(quantity)function.comparable()does not compare amounts. It checks whether these two quantities can be compared at all.80 'kg'and1 'g'are both masses, sotrue, regardless of the numbers)1 'cm'vs1 's'isfalse).The function predicts the
=and>operators, not the~equivalence operator (https://build.fhir.org/ig/HL7/FHIRPath/#fn-comparable).This matters for calendar units: a calendar
yearis equivalent to the UCUM year1 'a', but not comparable to it, because1 year = 1 'a'is empty per the spec (https://hl7.org/fhirpath/N1/#time-valued-quantities).