fix: return an explicit error when application creation yields an empty response - #63
Open
mjdavidson wants to merge 1 commit into
Open
fix: return an explicit error when application creation yields an empty response#63mjdavidson wants to merge 1 commit into
mjdavidson wants to merge 1 commit into
Conversation
…ty response When the Okta SDK accepts a create-application call but responds with no body (for example when a configuration value is silently rejected or normalized away), it returns neither an application object nor an error. The handler only checked for an error and returned the empty result as-is, so the tool surfaced no content and no explanation, making a rejected configuration look like a successful no-op. Add a guard that returns a clear error when the SDK returns no application and no error. Valid input is unaffected and still returns the created application.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_applicationreturnedNonewhen the SDK accepted the call but responded with an empty body (no app and no error), so a rejected/normalized configuration looked like a silent no-op. Adds a guard that returns a clear error when no application and no error come back; valid input is unaffected.Tests:
tests/test_create_application.py.