fix: exit cleanly when started without a stdio client - #67
Open
mjdavidson wants to merge 1 commit into
Open
Conversation
The console entrypoint wrapped server.main() in asyncio.run(). server.main() is synchronous and ends in the blocking mcp.run(), which returns None, so asyncio.run(None) raised 'ValueError: a coroutine was expected, got None'. A live stdio client masks this because mcp.run() blocks for the session, but launching without a client (stdin at EOF) makes mcp.run() return immediately and the entrypoint crashes. Call the already-synchronous server.main() directly and drop the unused asyncio import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The console entrypoint wrapped the synchronous
server.main()inasyncio.run().server.main()ends in the blockingmcp.run()and returnsNone, soasyncio.run(None)raisedValueError: a coroutine was expected, got Nonewhenever the server was launched without a stdio client attached. Calls the already-synchronousmain()directly.Tests:
tests/test_entrypoint.py.