fix: preserve SAML attribute statements on create and update - #70
Open
mjdavidson wants to merge 1 commit into
Open
fix: preserve SAML attribute statements on create and update#70mjdavidson wants to merge 1 commit into
mjdavidson wants to merge 1 commit into
Conversation
_build_application_model built the SDK model with Model(**app_config). For SAML apps, settings.signOn.attributeStatements is a list of SamlAttributeStatement, an anyOf union whose concrete member (expression/group) is only bound by the SDK's from_dict deserializer. The plain constructor left each union's actual_instance as None, so every attribute statement serialized to null and never reached Okta — created and updated SAML apps always came back with an empty attributeStatements list, and assertions carried only the NameID. Build the model via model_cls.from_dict(app_config) instead, which binds nested union members. Attribute statements now round-trip with their full content; other application types are unaffected (from_dict is the SDK's own deserializer).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SAML
attributeStatementswere dropped (returned as[]) on both create and update._build_application_modelbuilt the SDK model with the plain constructor, which leaves theSamlAttributeStatementanyOf union'sactual_instanceunset, so each statement serialized tonulland never reached Okta. Builds the model via the SDK'sfrom_dict, which binds the union members; other application types are unaffected.\n\nTests:tests/test_application_model.py.