fix: return raw application JSON from get_application so attribute statements are readable - #71
Open
mjdavidson wants to merge 1 commit into
Open
Conversation
…atements are readable get_application returned the typed SDK model, which the MCP layer serializes with pydantic model_dump. For SAML apps that renders settings.signOn.attributeStatements as opaque anyOf union wrappers (actual_instance / any_of_schemas) rather than their real type/name/namespace/ values, so a caller can't read back which attributes are configured even though they work at sign-on. The typed deserialization also raises on apps whose settings.signOn omits fields the SDK marks required. Fetch the application through the request executor and return Okta's JSON verbatim, matching the approach already used by list_applications. Attribute statements now read back with their real fields, and sparse apps no longer break the call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_applicationreturned the typed SDK model, which the MCP layer serializes with pydanticmodel_dump— rendering SAMLattributeStatementsas opaque anyOf union stubs (noname/values), and raising on apps with a sparsesettings.signOn. Returns Okta's JSON verbatim via the request executor, matching the approach used bylist_applications.\n\nTests:tests/test_get_application.py.