Updates to support Xcode 26 Beta - #239
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds support for Xcode 26 Beta, refines CI and documentation workflows, and updates README references
- Enforces
SendableonBrowserSigninProviderFactoryand modifiesCoalescedResultto use a custom queue forisActive - Moves
swift-docc-plugininto CI-only configuration and expands test matrix for Xcode 16.4 and 26 Beta - Corrects workspace filenames, adds badges and links, and includes a new authorization example in the README
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/BrowserSignin/Providers/AuthenticationServicesProvider.swift | Added Sendable requirement to protocol |
| Sources/AuthFoundation/Utilities/CoalescedResult.swift | Introduced a private DispatchQueue and sync isActive |
| Samples/README.md | Updated workspace filename |
| README.md | Added badges, documentation links, and auth example |
| Package@swift-5.10.swift | Conditional import of DocC plugin |
| Package.swift | Moved DocC plugin dependency to environment check |
| .github/workflows/tests.yaml | Expanded Swift versions and updated Xcode destinations |
| .github/workflows/documentation-ghpages.yaml | Updated Xcode path and DocC flags |
| .github/actions/setup-swift/versions.yaml | Added Swift 6.2 with Xcode 26 support |
Comments suppressed due to low confidence (1)
Sources/BrowserSignin/Providers/AuthenticationServicesProvider.swift:51
- Adding a
Sendablerequirement to this protocol is a breaking API change; consider documenting this impact and ensure all existing conforming types are updated to satisfySendable.
protocol BrowserSigninProviderFactory: Sendable {
AlexNachbaur
commented
Jun 30, 2025
bmitchelmore
approved these changes
Jul 4, 2025
AlexNachbaur
added a commit
that referenced
this pull request
Jul 4, 2025
* Support Xcode 26 Beta and Swift 6.2
* Improve test matrix to include more Xcode and Swift versions
* Swift Package Manager tests across macOS and Linux:
* Swift 5.10 _(macOS only)_
* Swift 6.0
* Swift 6.1
* Swift 6.2
* Xcode tests include:
* iPhone: 16.4, 18.2, 18.5
* tvOS: 18.5
* watchOS: 11.5
* visionOS: 1.0, 2.5
* macOS: 15
* Update README
* Only imports `swift-docc-plugin` when run in CI (or the `ENABLE_DOC_GENERATION` environment variable is set) to improve dependency resolution performance
* Test and CI workflow improvements
* Update swift language version detection script
* Reduce parallel iteration count for async tests to avoid flaky CI race conditions
* Do not parallelize Swift tests, due to limited CI runner speed
* Resolve inadequate test timings for CI
* Resolve unit test URLResponse race conditions
* Ensure logs can be preserved from failed swift tests
* Fix a collision in log output naming
* Ensure xcbeautify is installed on Linux
* Update to the newer CircleCI runner for UI tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swift-docc-pluginas a dependency within CI to improve performance when this is used by consuming projectsswift testtests, until it becomes GA