Ensure rpId property is checked for Authentication requests - #240
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds support for reading the top-level rpId property for authentication requests and includes a suite of unit tests covering all identifier-selection paths.
- Introduce a check for
json["rpId"]inString.relyingPartyIssuer - Supply new tests for explicit
rpId, U2F params, extensions, issuer fallback, and invalid URL cases
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Tests/OktaIdxAuthTests/RelyingParthIdentifierTests.swift | Added tests for each relying-party identifier scenario |
| Sources/OktaIdxAuth/Internal/Extensions/URL+WebAuthnExtensions.swift | Added branch to return root rpId for authentication |
Comments suppressed due to low confidence (2)
Tests/OktaIdxAuthTests/RelyingParthIdentifierTests.swift:21
- [nitpick] The test name
testExplicitChallengeIdentifieris ambiguous; consider renaming totestExplicitRegistrationIdentifierortestExplicitRelyingPartyIdFromRPfor clarity.
func testExplicitChallengeIdentifier() throws {
Tests/OktaIdxAuthTests/RelyingParthIdentifierTests.swift:36
- Consider adding a test where both
rpIdandu2fParamsare present to verify thatrpIdtakes precedence overu2fParamsas implemented.
func testExplicitAuthenticationIdentifier() throws {
FeiChen-okta
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.