Relocate JSON features to its own utility library - #258
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR relocates JSON functionality into a separate utility library, following PR #257 and preparing for the changes in PR #248. This refactoring improves modularity by extracting JSON-related features from the main AuthFoundation library.
- Creates a new standalone JSON library module
- Updates import statements across the codebase to use the new JSON library
- Modifies package configuration and podspec to include the new JSON target
Reviewed Changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Package.swift | Adds new JSON library target and updates dependencies |
| OktaAuthFoundation.podspec | Includes JSON source files in the podspec |
| Sources/AuthFoundation/* | Updates files to import the new JSON module |
| Sources/OktaIdxAuth/* | Updates files to import the new JSON module |
| Sources/OktaDirectAuth/* | Updates files to import the new JSON module |
| Tests/JSONTests/* | Adds new test files for the JSON module |
| Tests/*/Tests.swift | Updates test files to import the new JSON module |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
AlexNachbaur
dismissed
IldarAbdullin-okta’s stale review
October 2, 2025 16:28
The base branch was changed.
AlexNachbaur
force-pushed
the
relocate-json-libs
branch
from
October 2, 2025 17:51
0aed5f8 to
ba81f99
Compare
jaredperreault-okta
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows on #257, separating JSON features into a stand-alone library. This is to lay the groundwork to simplify the changes in #248.