Skip to content

Relocate JSON features to its own utility library - #258

Merged
AlexNachbaur merged 5 commits into
masterfrom
relocate-json-libs
Oct 3, 2025
Merged

Relocate JSON features to its own utility library#258
AlexNachbaur merged 5 commits into
masterfrom
relocate-json-libs

Conversation

@AlexNachbaur

Copy link
Copy Markdown
Contributor

This follows on #257, separating JSON features into a stand-alone library. This is to lay the groundwork to simplify the changes in #248.

Copilot AI review requested due to automatic review settings September 24, 2025 23:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR relocates JSON functionality into a separate utility library, following PR #257 and preparing for the changes in PR #248. This refactoring improves modularity by extracting JSON-related features from the main AuthFoundation library.

  • Creates a new standalone JSON library module
  • Updates import statements across the codebase to use the new JSON library
  • Modifies package configuration and podspec to include the new JSON target

Reviewed Changes

Copilot reviewed 22 out of 23 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Package.swift Adds new JSON library target and updates dependencies
OktaAuthFoundation.podspec Includes JSON source files in the podspec
Sources/AuthFoundation/* Updates files to import the new JSON module
Sources/OktaIdxAuth/* Updates files to import the new JSON module
Sources/OktaDirectAuth/* Updates files to import the new JSON module
Tests/JSONTests/* Adds new test files for the JSON module
Tests/*/Tests.swift Updates test files to import the new JSON module

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@IldarAbdullin-okta IldarAbdullin-okta left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from relocate-common-libs to master October 2, 2025 16:28
@AlexNachbaur
AlexNachbaur dismissed IldarAbdullin-okta’s stale review October 2, 2025 16:28

The base branch was changed.

@AlexNachbaur
AlexNachbaur merged commit b794672 into master Oct 3, 2025
22 checks passed
@AlexNachbaur
AlexNachbaur deleted the relocate-json-libs branch October 3, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants