Accept array form for aud claim per RFC 7519 §4.1.3 - #280
Open
RicardoKoch wants to merge 1 commit into
Open
Conversation
DefaultIDTokenValidator currently performs a strict scalar comparison against `clientId`. RFC 7519 §4.1.3 and OIDC Core 1.0 §3.1.3.7 both permit `aud` to be a JSON array of strings; tokens emitted in that form are silently rejected today. Extend the `.audience` check to: - When `aud` is a JSON array, require `clientId` to be a member. - Otherwise, fall back to the existing scalar comparison. Adds two regression tests (`testAudienceArrayContainingClientIdSucceeds`, `testAudienceArrayNotContainingClientIdFails`) following the existing test-fixture conventions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefaultIDTokenValidator currently performs a strict scalar comparison against
clientId. RFC 7519 §4.1.3 and OIDC Core 1.0 §3.1.3.7 both permitaudto be a JSON array of strings; tokens emitted in that form are silently rejected today.Extend the
.audiencecheck to:audis a JSON array, requireclientIdto be a member.Adds two regression tests (
testAudienceArrayContainingClientIdSucceeds,testAudienceArrayNotContainingClientIdFails) following the existing test-fixture conventions.Closes #281