fixes issues causing failure of creation of OAuth application (#2708)

Author: aditya-okta

okta/services/idaas/resource_okta_app_oauth.go

@@ -514,8 +514,18 @@ func resourceAppOAuthCreate(ctx context.Context, d *schema.ResourceData, meta in
 
 func setAppOauthGroupsClaim(ctx context.Context, d *schema.ResourceData, meta interface{}) error {
 	raw, ok := d.GetOk("groups_claim")
+	// Log deprecation warning
+	logger(meta).Warn("groups_claim is deprecated and will be removed in a future version. Please use Authorization Server Claims (okta_auth_server_claim) or app profile configuration instead.")
+
+	c := meta.(*config.Config)
+	if c.IsOAuth20Auth() {
+		logger(meta).Warn("setting groups_claim disabled with OAuth 2.0 API authentication")
+		return nil
+	}
+
 	apiSupplement := getAPISupplementFromMetadata(meta)
 	appID := d.Id()
+
 	if !ok {
 		gc := &sdk.AppOauthGroupClaim{
 			Name:      "",
@@ -539,15 +549,6 @@ func setAppOauthGroupsClaim(ctx context.Context, d *schema.ResourceData, meta in
 		return nil
 	}
 
-	// Log deprecation warning
-	logger(meta).Warn("groups_claim is deprecated and will be removed in a future version. Please use Authorization Server Claims (okta_auth_server_claim) or app profile configuration instead.")
-
-	c := meta.(*config.Config)
-	if c.IsOAuth20Auth() {
-		logger(meta).Warn("setting groups_claim disabled with OAuth 2.0 API authentication")
-		return nil
-	}
-
 	// For now, keep the old behavior but with warnings
 	// TODO: Remove in future version - functionality temporarily maintained for backward compatibility