Skip to content

feat: fix papercuts around domain verifications - #2871

Open
ohookins wants to merge 3 commits into
okta:masterfrom
ohookins:feat-domain-verification-papercuts
Open

feat: fix papercuts around domain verifications#2871
ohookins wants to merge 3 commits into
okta:masterfrom
ohookins:feat-domain-verification-papercuts

Conversation

@ohookins

@ohookins ohookins commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

There are two problems with the okta_domain_verification and okta_email_domain_verification resources right now:

  1. If the custom domain / email domain is already verified by DNS, attempting to create these resources (by triggering another verification) will fail with a 400 error.
  2. There's no way to import the current verification status of the domain.

I've attempted to solve both of these problems by

  1. Querying the domain verification status before attempting to verify again, so avoiding triggering an API request which unfortunately is not idempotent.
  2. Allowing the user to import the domain verification and avoid case (1) altogether if desired.

Fixes #1909

@ohookins
ohookins marked this pull request as ready for review June 26, 2026 04:59
@github-actions
github-actions Bot requested a review from aditya-okta June 26, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

okta_email_domain_verification throws 400 error if email domain is already verified

1 participant