feat: add inline hook and event hook resources - #2887
Open
pranav-okta wants to merge 4 commits into
Open
Conversation
| id := state.ID.ValueString() | ||
|
|
||
| client := r.Config.OktaIDaaSClient.OktaSDKClientV6() | ||
| httpResp, err := client.EventHookAPI.DeleteEventHook(ctx, id).Execute() |
Contributor
There was a problem hiding this comment.
Does deletion of the event hook work without deactivation ?
| "key": header.Key, | ||
| "value": header.Value, | ||
| client := r.Config.OktaIDaaSClient.OktaSDKClientV6() | ||
| httpResp, err := client.InlineHookAPI.DeleteInlineHook(ctx, id).Execute() |
Contributor
There was a problem hiding this comment.
Does deletion of the event hook work without deactivation ?
| }, | ||
| }, | ||
| Blocks: map[string]schema.Block{ | ||
| "channel": schema.SingleNestedBlock{ |
Contributor
There was a problem hiding this comment.
I can see that the type of this field has changed from
Type: schema.TypeMap
to
schema.SingleNestedBlock
Did this bring up any issues when you tested migrating the resource ?
| Description: "Version of the inline hook type.", | ||
| Optional: true, | ||
| }, | ||
| "channel_json": { |
Contributor
There was a problem hiding this comment.
What about channel_json ? We can't migrate unless we support this existing field, even if it isn't part of the request body.
| Description: "Display name for the event hook", | ||
| Required: true, | ||
| }, | ||
| "status": schema.StringAttribute{ |
Contributor
There was a problem hiding this comment.
With this we cannot activate or deactivate the event hook by updating the value of status
dhiwakar-okta
requested changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://oktainc.atlassian.net/browse/OKTA-1218464