DO NOT MERGE: feat: add templates and brands resource - #2891
Conversation
There was a problem hiding this comment.
Why is it Sm everywhere, including the filename if this is for SMS ?
| Description: "Human-readable name of the Template", | ||
| Optional: true, | ||
| }, | ||
| "template": schema.StringAttribute{ |
There was a problem hiding this comment.
Please fix this description
| body.SetName(plan.Name.ValueString()) | ||
| body.SetTemplate(plan.Template.ValueString()) | ||
| body.SetType(plan.Type.ValueString()) | ||
| createReq = createReq.SmsTemplate(*body) |
There was a problem hiding this comment.
What about body.SetTranslations(...) ?
If it is a genuine issue, please investigate why this was missed .
There was a problem hiding this comment.
Where is the docs/**/*.md file for this ?
There was a problem hiding this comment.
Where is the docs/**/*.md file for this ?
There was a problem hiding this comment.
Where is the docs/**/*.md file for this ?
| Optional: true, | ||
| }, | ||
| "language": schema.StringAttribute{ | ||
| Description: "The language specified as an [IETF BCP 47 language tag](https://datatracker.", |
There was a problem hiding this comment.
Please fix the description
There was a problem hiding this comment.
It looks like this is still EA @pranav-okta
/api/v1/brands/{brandId}/templates/email/{templateName}/customizations
Please remove this resource file along with the corresponding tests from this PR for the time being.
Update the PR's description too.
dhiwakar-okta
left a comment
dhiwakar-okta
left a comment
There was a problem hiding this comment.
Please review my comments.
- Add missing docs for okta_brands_templates_email_customization resource - Add missing example for okta_brands_templates_email_customization - Fix okta_template_sms: correct template/type to Optional, replace nested block translations with Map of String - Fix okta_email_template_settings: correct recipients to Optional
024d05e to
49be7e3
Compare
pranav-okta
changed the title
2 participants
DO NOT MERGE - This is a resource for an EA API
JIRA: https://oktainc.atlassian.net/browse/OKTA-1224208