-
Notifications
You must be signed in to change notification settings - Fork 264
feat: add threats_configuration resource and datasource #2893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pranav-okta
wants to merge
7
commits into
codegen-migration-phase-2
Choose a base branch
from
new-threats_configuration_resource
base: codegen-migration-phase-2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a46e1e1
feat: add threats_configuration resource and datasource
pranav-okta 9c5f6bf
test: fix test for threat configuration
pranav-okta 8d6d7c5
Merge branch 'master' into new-threats_configuration_resource
pranav-okta 80a63d4
refactor: rename new resources to old resources names
pranav-okta e9f1155
docs: add and update threat_insight_settings documentation
pranav-okta b03e264
Merge branch 'master' into new-threats_configuration_resource
pranav-okta c0322b0
Merge branch 'codegen-migration-phase-2' into new-threats_configurati…
pranav-okta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| data "okta_threats_configuration" "test" {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| resource "okta_threats_configuration" "test" { | ||
| action = "none" | ||
| } | ||
144 changes: 144 additions & 0 deletions
144
okta/services/idaas/data_source_okta_threats_configuration.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
32 changes: 32 additions & 0 deletions
32
okta/services/idaas/data_source_okta_threats_configuration_test.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a Go resource file for
okta_threats_configurationdefined anywhere in this PR. The name of the resource seems to beokta_threat_insight_settingsor is that not the same asokta_threats_configuration?