Skip to content

fix: surface API errors in okta_group_memberships Update #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aknight-bw wants to merge 2 commits into
base: master
Choose a base branch
from
+1,121 −2
Open

fix: surface API errors in okta_group_memberships Update #2921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6961b9
fix: surface 403 errors in okta_group_memberships Update
aknight-bw Aug 5, 2026
436992f
fix: correct VCR cassettes for TestAccResourceOktaGroupMemberships_Is…
aknight-bw Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions okta/services/idaas/resource_okta_group_memberships.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,12 +196,12 @@ func resourceGroupMembershipsUpdate(ctx context.Context, d *schema.ResourceData,

err := addGroupMembers(ctx, client, groupId, usersToAdd)
if err != nil {
diag.FromErr(err)
return diag.FromErr(err)
}

err = removeGroupMembers(ctx, client, groupId, usersToRemove)
if err != nil {
diag.FromErr(err)
return diag.FromErr(err)
}

return nil
Expand Down
45 changes: 45 additions & 0 deletions okta/services/idaas/resource_okta_group_memberships_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package idaas_test
import (
"errors"
"fmt"
"regexp"
"strings"
"testing"

Expand Down Expand Up @@ -79,6 +80,50 @@ func TestAccResourceOktaGroupMemberships_GH2775(t *testing.T) {
})
}

// TestAccResourceOktaGroupMemberships_Issue2866 addresses https://github.com/okta/terraform-provider-okta/issues/2866
// Verifies that an API error (e.g. 403 E0000006 on a group with an Application Administrator role binding)
// during okta_group_memberships Update is surfaced as an apply error rather than being silently swallowed.
func TestAccResourceOktaGroupMemberships_Issue2866(t *testing.T) {
step1 := `
resource "okta_group" "test" {
name = "TestACC Group 2866"
description = "Group for issue 2866 test"
}
resource "okta_group_memberships" "test" {
group_id = okta_group.test.id
users = ["00u2866TESTUSER1d7"]
}
`
step2 := `
resource "okta_group" "test" {
name = "TestACC Group 2866"
description = "Group for issue 2866 test"
}
resource "okta_group_memberships" "test" {
group_id = okta_group.test.id
users = ["00u2866TESTUSER1d7", "00u2866TESTUSER2d7"]
}
`
acctest.OktaResourceTest(t, resource.TestCase{
PreCheck: acctest.AccPreCheck(t),
ErrorCheck: testAccErrorChecks(t),
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactoriesForTestAcc(t),
CheckDestroy: checkUserDestroy,
Steps: []resource.TestStep{
{
Config: step1,
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr("okta_group_memberships.test", "users.#", "1"),
),
},
{
Config: step2,
ExpectError: regexp.MustCompile(`You do not have permission to perform the requested action`),
},
},
})
}

// TestAccResourceOktaGroupMemberships_Issue1072 addresses https://github.com/okta/terraform-provider-okta/issues/1072
func TestAccResourceOktaGroupMemberships_Issue1072(t *testing.T) {
acctest.OktaResourceTest(t, resource.TestCase{
Expand Down
Loading