Parametrize timeout and consider Galera timeouts#14
Open
paescuj wants to merge 1 commit intoolafz:masterfrom
Open
Parametrize timeout and consider Galera timeouts#14paescuj wants to merge 1 commit intoolafz:masterfrom
paescuj wants to merge 1 commit intoolafz:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the timeout value parameterizable, like the other values.
What where your thoughts about the timeout value of 10?
I think the correct value should be >15s because of the evs.inactive_timeout of 15s coming from Galera, so we have to wait at least 15s to retrieve a defined status.
Please correct me if I am wrong. I'm open for discussions.