[pull] develop from hackforla:develop - #8
Merged
Conversation
…2860) Follow-up to #2856. hanapotski's review approved the PR but flagged that internal state/action names (orgNameFilter, ORG_NAME_FILTER_UPDATED) still referenced "org name" even though the field now searches multiple listing fields and the UI label was changed to "Search". Mechanical rename across state/reducer/hook/action-type/call-sites: orgNameFilter -> searchFilter, ORG_NAME_FILTER_UPDATED -> SEARCH_FILTER_UPDATED, useOrgNameFilter -> useSearchFilter. The shareable "?name=" URL query parameter key is unchanged, so existing shared/bookmarked search URLs keep working. Not addressed (per review, both explicitly non-blocking): - "expanded matching scope" observation describes intended behavior from #2117, not something to change. - performance note on rebuilding the per-stakeholder searchable string on each filter pass is consistent with how every other filter in useOrganizationBests.ts already works, and the reviewer called it negligible at current scale / worth monitoring, not urgent. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )