Skip to content

Add note about January 2021 fixes to jar signer#1

Open
zathras wants to merge 1 commit intooliverlietz:masterfrom
zathras:patch-1
Open

Add note about January 2021 fixes to jar signer#1
zathras wants to merge 1 commit intooliverlietz:masterfrom
zathras:patch-1

Conversation

@zathras
Copy link
Copy Markdown

@zathras zathras commented Jan 17, 2022

This repos comes up in searches, and is fairly widely followed. Could you add this note, please? If you like, you're more than welcome to incorporate the JAR signer fix. It's pretty simple - it's in the history, and I'd be happy to discuss if I could figure out your contact info :-)

@oliverlietz
Copy link
Copy Markdown
Owner

@zathras, Which JDK are you using? With both Oracle JDK and OpenJDK I get package sun.security.tools.keytool does not exist. The package is not part of tools.jar.

java version "1.8.0_321"
Java(TM) SE Runtime Environment (build 1.8.0_321-b07)
Java HotSpot(TM) 64-Bit Server VM (build 25.321-b07, mixed mode)
openjdk version "1.8.0_312"
OpenJDK Runtime Environment (build 1.8.0_312-bre_2021_10_20_23_15-b00)
OpenJDK 64-Bit Server VM (build 25.312-b00, mixed mode)

@zathras
Copy link
Copy Markdown
Author

zathras commented Jan 20, 2022

That's odd. I double-checked on Linux, and (after I fixed an ancient bug in the clean target due to the case-sensitive filesystem), it worked for me on Linux, as well as MacOS. I added the version details to https://github.com/zathras/java.net/blob/master/hdcookbook/README.md

Are you using ant to build? I had to add a javac command-line argument to allow access to more of the sun.* stuff. With that said, there might be other options the ant build passes in, so this might or might not be the problem.

Ah, there it is: -XDignore.symbol.file in the build.xml for the JAR signer tool. I added a note about this to the README.md.

@oliverlietz
Copy link
Copy Markdown
Owner

No Ant anymore, I changed the build to use Maven 10 years ago. The additional compiler argument (-XDignore.symbol.file) is key and I had to add an additional system dependency on rt.jar (contains package sun.security.tools.keytool).

@zathras
Copy link
Copy Markdown
Author

zathras commented Jan 21, 2022

Makes sense. I had to figure out where to get ant for MacOS to get the original to work.

@oliverlietz
Copy link
Copy Markdown
Owner

@zathras
Copy link
Copy Markdown
Author

zathras commented Jan 21, 2022

Yes, that's where I found it too.

But anyway, could you add links to the archive of the original repo and the archive of hdcookbook.com to the README, please? It's good to leave breadcrumbs, in case someone wants to reconstruct this stuff some day. That's basically why I fixed it for 1.8.

@oliverlietz
Copy link
Copy Markdown
Owner

@Zathra, Sure. Now that schemagen and security are fixed and java.net and hdcookbook.com are dead I will do some clean up and start to modernize Authoring and Disc Creation Tools and site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants