Add note about January 2021 fixes to jar signer#1
Add note about January 2021 fixes to jar signer#1zathras wants to merge 1 commit intooliverlietz:masterfrom
Conversation
|
@zathras, Which JDK are you using? With both Oracle JDK and OpenJDK I get |
|
That's odd. I double-checked on Linux, and (after I fixed an ancient bug in the clean target due to the case-sensitive filesystem), it worked for me on Linux, as well as MacOS. I added the version details to https://github.com/zathras/java.net/blob/master/hdcookbook/README.md Are you using ant to build? I had to add a javac command-line argument to allow access to more of the sun.* stuff. With that said, there might be other options the ant build passes in, so this might or might not be the problem. Ah, there it is: -XDignore.symbol.file in the build.xml for the JAR signer tool. I added a note about this to the README.md. |
|
No Ant anymore, I changed the build to use Maven 10 years ago. The additional compiler argument ( |
|
Makes sense. I had to figure out where to get ant for MacOS to get the original to work. |
|
Ant is available via Homebrew: https://formulae.brew.sh/formula/ant#default |
|
Yes, that's where I found it too. But anyway, could you add links to the archive of the original repo and the archive of hdcookbook.com to the README, please? It's good to leave breadcrumbs, in case someone wants to reconstruct this stuff some day. That's basically why I fixed it for 1.8. |
This repos comes up in searches, and is fairly widely followed. Could you add this note, please? If you like, you're more than welcome to incorporate the JAR signer fix. It's pretty simple - it's in the history, and I'd be happy to discuss if I could figure out your contact info :-)