Skip to content

Backend#258

Open
oliyh wants to merge 2 commits intomasterfrom
backend
Open

Backend#258
oliyh wants to merge 2 commits intomasterfrom
backend

Conversation

@oliyh
Copy link
Copy Markdown
Owner

@oliyh oliyh commented Mar 27, 2026

No description provided.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@marksto
Copy link
Copy Markdown
Contributor

marksto commented Mar 27, 2026

@oliyh Is this an Easter gift for us all? 😅 This already looks super cool! Godspeed!

Comment on lines +31 to +34
;; Collection format handling
(wrap-collection-format-schema [backend array-schema collection-format]
"Wraps an array schema to handle a specific collection format string
(e.g. 'csv', 'ssv'). Returns array-schema unchanged if not applicable.")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the only place where impedance mismatch occurs. These "collection formats" are not inherent in schemas, right? Maybe we can decompose it into atomic methods instead — two predicates (string-schema?, array-schema?) and one constructor? Or, given that we've already allowed OpenAPI specifics to leak into this protocol (the leaf-schema method), is it fine to leave this method as is?

@marksto
Copy link
Copy Markdown
Contributor

marksto commented Mar 27, 2026

Oliver, if you need any help porting the Plumatic Schema-specific part of the codebase I recently implemented in order to fully support the "parameter aliases" feature, just give me a nod. These are basically:

Hopefully, for Malli we won't have to re-implement alias-schema/unalias-data with custom pre-walks with path, but will rather use Malli schemas built-in introspection capabilities (if they are sufficient enough, I didn't check yet, but it looks like we should be able to leverage mu/subschemas, mu/path->in, and friends). As for the registry, since Malli is fully supported by Babashka, we'll only need to implement a lazy variant (similar to the LazyRegistry instance).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants