Tag Vivaldi's window class case-insensitively in browser.lua - #9279
Open
reverb256 wants to merge 2 commits into
Open
Tag Vivaldi's window class case-insensitively in browser.lua#9279reverb256 wants to merge 2 commits into
reverb256 wants to merge 2 commits into
Conversation
Hyprland reports Vivaldi's window class as lowercase "vivaldi-stable", but the chromium-based-browser rule in default/hypr/apps/browser.lua spelled it with a capital V, so Vivaldi never matched and missed the tile + opacity treatment the other Chromium browsers get. Match both cases the way the neighbouring alternatives already do. Fixes omacom#9274.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9274.
Problem
Hyprland reports Vivaldi's window class in lowercase as
vivaldi-stable, but thechromium-based-browserrule indefault/hypr/apps/browser.luaspelled it with a capital V:Because the other alternatives already cover both cases (
[cC]hrom,[bB]rave,[mM]icrosoft), Vivaldi never matches the rule, keeps the generic-default-opacitytag, and misses thetile = true+opacity = "1.0 0.985"treatment the other Chromium browsers get.Change
Match the class in both cases, consistent with its neighbouring alternatives:
Test
Adds
test/shell.d/vivaldi-window-class-test.sh, a regression guard that assertsbrowser.luaboth tags achromium-based-browserwindow class and matches Vivaldi case-insensitively (and fails if the case-sensitive spelling returns):bash -n test/shell.d/vivaldi-window-class-test.sh— cleanbash test/shell.d/vivaldi-window-class-test.sh— passesNote: the test filename is scoped to Vivaldi to avoid colliding with #8968, which independently adds
test/shell.d/browser-tags-test.shfor the Brave-origin rule.