Fix $STANDARD_INFORMATION parsing for 48-byte values#146
Merged
omerbenamram merged 2 commits intomasterfrom Jan 1, 2026
Merged
Fix $STANDARD_INFORMATION parsing for 48-byte values#146omerbenamram merged 2 commits intomasterfrom
omerbenamram merged 2 commits intomasterfrom
Conversation
Parse $STANDARD_INFORMATION based on the resident value length (48 vs 72 bytes) so we don't read past the value into the next attribute header. Add unit and integration regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$STANDARD_INFORMATIONparsing to respect the resident value length (48 vs 72 bytes).owner_id/security_id/quota/usn).samples/MFTentry 5 with a 48-byte$STANDARD_INFORMATION).Test plan
cargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningscargo test -p mft --all-featuresNote
Ensures
$STANDARD_INFORMATIONis parsed according to its resident value length, avoiding reads into subsequent attribute headers.resident.data_sizeforStandardInformationand parse via newStandardInfoAttr::from_slice(supports 48- and 72-byte layouts)samples/MFTentry 5 to prevent leakage into next attribute headerWritten by Cursor Bugbot for commit 8b1668a. This will update automatically on new commits. Configure here.