✨ Hanami & ROM support#163
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for ROM (Ruby Object Mapper) as a new ORM adapter for OmniAuth Identity. ROM is a persistence and mapping toolkit that provides a clean separation between relations and entities, making it suitable for Hanami applications.
- Added a new ROM model adapter that implements OmniAuth Identity's interface
- Created comprehensive test coverage for ROM functionality including authentication and owner associations
- Updated CI workflows and build configurations to include ROM testing across multiple Ruby versions
Reviewed Changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/omniauth/identity/models/rom.rb | Core ROM adapter implementation with authentication and data mapping logic |
| spec_orms/rom_spec.rb | Complete test suite covering ROM model functionality and edge cases |
| lib/omniauth/identity.rb | Added autoload for the new ROM adapter |
| Gemfile | Added rom-sql dependency for development |
| Rakefile | Updated test tasks to include ROM specs |
| Appraisals | Added ROM appraisal configurations for different Ruby versions |
| gemfiles/rom_r3*.gemfile | Gemfile configurations for ROM testing |
| .github/workflows/*.yml | Updated CI workflows to test ROM across all supported Ruby versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
pboling
force-pushed
the
feat/adapter-rom
branch
3 times, most recently
from
534df6e to
4e2d8cc
Compare
pboling
force-pushed
the
feat/adapter-rom
branch
from
4e2d8cc to
94b6cec
Compare
Minimum allowed line rate is |
Pull Request Test Coverage Report for Build 18478619600Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.