chore: small code cleanup of client.go#1
Open
pcjacobse wants to merge 1 commit into
Open
Conversation
Did a small cleanup of the code, mostly of client.go. Also cleaned up some linting issues found by golangci-lint. There are a few notes on things I have seen: - Plain getters / setters are not common / recommended in Go, it is more common to just expose the variables. - pkg/errors package is abandoned since 2021, most functionality is in the native package - context.Context should not be passed as nil
LeonB
force-pushed
the
master
branch
2 times, most recently
from
June 2, 2026 15:34
c942f00 to
cfdf2db
Compare
Author
|
test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did a small cleanup of the code, mostly of client.go. Also cleaned up some linting issues found by golangci-lint. There are a few notes on things I have seen: