fix: replace nil with unspecified for :distant-foreground in Emacs 30.2#128
Closed
eliaskanelis wants to merge 1 commit into
Closed
fix: replace nil with unspecified for :distant-foreground in Emacs 30.2#128eliaskanelis wants to merge 1 commit into
eliaskanelis wants to merge 1 commit into
Conversation
In Emacs 30.2, setting :distant-foreground to nil is invalid and causes a warning: "Setting attribute ':distant-foreground' of face 'highlight': nil value is invalid, use 'unspecified' instead." Replace nil with unspecified in both the highlight and lazy-highlight faces for both monokai-class and monokai-256-class to comply with Emacs 30.2+ requirements. Fixes: Warning on startup with Emacs 30.2+
Author
|
Duplicate with #125 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Emacs 30.2 Compatibility: :distant-foreground nil → unspecified
Problem
Users running Emacs 30.2+ see this warning on startup:
Root Cause
The
highlightandlazy-highlightfaces in monokai-theme.el set:distant-foregroundtonil, which is no longer valid in Emacs 30.2.Emacs now requires
unspecifiedfor undefined face attributes.Solution
Replace
nilwithunspecifiedfor the:distant-foregroundattribute in:highlightface (bothmonokai-classandmonokai-256-class)lazy-highlightface (bothmonokai-classandmonokai-256-class)Changes
Testing
✅ Tested on Emacs 30.2
✅ No startup warnings
✅ Theme loads correctly