fix(renovate): match talosctl by its package name in talos group - #2368
Merged
Conversation
Signed-off-by: Devin Buhl <devin@buhl.casa>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2366, which removed the wrong name from the
talosgroup. After it merged renovate opened the talosctl bump underrenovate/mise-tools(#2367) and the dashboard still reported "Group Size Not Met" for the installer alone.Renovate's mise manager resolves
talosctlvia its asdf tooling table withpackageName: 'siderolabs/talos'anddepName: talosctl(lib/modules/manager/asdf/upgradeable-tooling.ts), andmatchPackageNamesmatches onpackageName. Sosiderolabs/taloswas the entry that matched talosctl all along; the baretalosctlname never matched anything. This restoressiderolabs/talosand dropstalosctl, keepingminimumGroupSize: 2so installer + talosctl land in one PR.Validated with
renovate-config-validator. Once this merges, renovate should move the talosctl update from #2367 into therenovate/talosbranch together with the installer bump.