1238 migrate package back to src

[zzggo]

Related Issue

Closes #1238

Summary of Changes

Need Regression Testing

• Yes
• No

Risk Assessment

• Low
• Medium
• High

Additional Notes

Screenshots (if applicable)

[claude]

Claude finished @zzggo's task —— View job

---

📋 Code Review Complete

I've thoroughly analyzed this large-scale migration that consolidates separate packages into the apps/extension structure. Here's my comprehensive review:

🔍 Migration Overview

What Actually Happened:

• FROM: Separate packages/core/, packages/data-model/, and packages/extension-shared/
• TO: Consolidated into apps/extension/src/core/, apps/extension/src/data-model/, and apps/extension/src/extension-shared/
• Result: Simplified monorepo structure (moved from multi-package to single extension package)

PR Statistics: 892 additions, 6695 deletions across 100 files

---

✅ Strengths

1. Architectural Simplification

• Eliminates complex multi-package dependencies
• Reduces build complexity and inter-package versioning issues
• Aligns with the documented architecture in CLAUDE.md

2. Import Path Consistency

• Updated imports from @/core to @/core/service and @/core/utils
• Maintained TypeScript path mapping (@/* → ./src/*)
• Preserved architectural boundaries between UI/background layers

3. Configuration Updates

• ESLint configs updated appropriately for new structure
• Package.json properly consolidated dependencies
• Webpack configurations maintained

---

⚠️ Issues & Concerns

1. Critical Build Configuration Gap

The root webpack.config.ts still references the old structure:

// Line 4-6: Still pointing to apps/extension/build/
import commonConfig from './apps/extension/build/webpack.common.config';
import dev from './apps/extension/build/webpack.dev.config';
import pro from './apps/extension/build/webpack.pro.config';

Risk: Build failures when running from root directory

2. Missing _raw Directory Migration

- apps/extension/_raw/manifest.json (DELETED)
- apps/extension/_raw/react-devtools.js (DELETED)

Risk: Extension manifest missing, preventing Chrome extension loading

3. Import Path Consistency Issues

Some files may still have residual import paths that reference the old structure. Need verification that all @/core, @/data-model, @/extension-shared imports are updated.

4. Test Configuration

Several test files were moved but test configurations in vitest.config.ts and playwright.config.ts may need updates for new paths.

---

🔒 Security Assessment

✅ Low Risk - This is primarily a structural reorganization that:

• Doesn't modify business logic or security-sensitive code
• Maintains existing architectural boundaries
• Preserves background/UI separation patterns

---

🏃‍♂️ Performance Considerations

Potential Improvements:

• Faster Builds: Eliminates inter-package dependency resolution
• Simpler Dependencies: Single package.json reduces complexity
• Better Tree Shaking: Consolidated imports may improve bundling

---

⭐ Test Coverage

Test File Migration Status:

• ✅ Unit tests moved and updated
• ✅ Integration tests preserved
• ❓ E2E test paths may need verification
• ❓ Vitest configuration alignment needed

---

🚦 Breaking Changes Assessment

Medium Risk due to:

1. Build System Changes: Root build commands may fail
2. Missing Static Assets: Manifest deletion could break extension loading
3. Import Updates: Any missed import updates will cause runtime errors

---

🔧 Recommendations

Immediate Actions Required:

1. Fix Root Webpack Config - Update paths in root webpack.config.ts
2. Restore Extension Manifest - Ensure _raw/manifest.json exists and is properly referenced
3. Verify Import Completeness - Run comprehensive search for any missed import updates
4. Update Root Scripts - Ensure pnpm dev, pnpm build work from root

Before Merging:

1. Build Test: Run pnpm build to ensure no build failures
2. Extension Load Test: Verify Chrome extension loads properly
3. Import Verification: Run pnpm lint to catch any import issues
4. E2E Verification: Run pnpm test:e2e to ensure test paths work

---

📊 Overall Assessment

✅ Recommended for Merge after addressing critical issues above.

This is a well-executed consolidation that simplifies the codebase architecture. The migration correctly maintains architectural boundaries and updates most configurations appropriately. The few remaining issues are straightforward build/config fixes rather than fundamental problems with the approach.

Risk Level: Medium → Low (once build configs are fixed)

---