Skip to content

Round down position availableBalance to avoid exceeding capacity #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turbolent merged 1 commit into from
Apr 9, 2026
Merged

Round down position availableBalance to avoid exceeding capacity #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cadence/contracts/FlowALPv0.cdc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1829,7 +1829,8 @@ access(all) contract FlowALPv0 {
withdrawBal: withdrawBal,
targetHealth: view.minHealth
)
return FlowALPMath.toUFix64Round(uintMax)
// Round down to avoid allowing withdrawal of more than is safe
return FlowALPMath.toUFix64RoundDown(uintMax)
}

/// Returns the health of the given position, which is the ratio of the position's effective collateral
Expand Down
Loading