feat: Add UInt256 precision improvements to DeFiBlocks#12
Closed
nialexsan wants to merge 1 commit into
Closed
Conversation
- Add DFBMathUtils contract for high-precision math operations - Create DFBv2 with AutoBalancerV2 using UInt256 calculations - Add AutoBalancerV2Adapter with utility functions - Include comprehensive tests demonstrating precision improvements - Add documentation explaining the improvements and migration guide This follows the same pattern as TidalProtocol's precision upgrade, providing 18-decimal fixed-point arithmetic for better accuracy in DeFi calculations.
Contributor
|
To be honest, I doubt the source of discrepancies originate from the AutoBalancer's decimal precision. Even after the precision refactor, the protocol pulls funds by Additionally, I would really hope that That said, I think we should integrate this branch as a last resort after pulling latest from onflow/FlowALP#31 into the end-to-end test scenarios. |
Contributor
Author
|
merged another change #14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows the same pattern as TidalProtocol's precision upgrade, providing 18-decimal fixed-point arithmetic for better accuracy in DeFi calculations.