Skip to content

[Access] Completely disable bitswap reproviding when bitswap-reprovide-enabled=false #8498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peterargue wants to merge 2 commits into
base: v0.47
Choose a base branch
from
Open

[Access] Completely disable bitswap reproviding when bitswap-reprovide-enabled=false #8498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ea00ae
[Access] Completely disable bitswap reproviding when bitswap-reprovid…
peterargue Mar 19, 2026
a65ed97
disable reproviding on public network if configured
peterargue Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cmd/access/node_builder/access_node_builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,6 +842,10 @@ func (builder *FlowAccessNodeBuilder) BuildExecutionSyncComponents() *FlowAccess
blob.WithParentBlobService(bs),
}

if !builder.BitswapReprovideEnabled {
opts = append(opts, blob.WithReprovideInterval(-1))
}

net := builder.AccessNodeConfig.PublicNetworkConfig.Network

var err error
Expand Down
12 changes: 11 additions & 1 deletion network/p2p/blob/blob_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,11 @@ func NewBlobService(
}
}).
AddWorker(func(ctx irrecoverable.SignalerContext, ready component.ReadyFunc) {
if bs.config.ReprovideInterval < 0 {
ready()
return
}

// New creates and starts the reprovider (non-blocking)
reprovider, err := provider.New(ds,
provider.Online(r),
Expand All @@ -182,7 +187,9 @@ func NewBlobService(

var err *multierror.Error

err = multierror.Append(err, bs.reprovider.Close())
if bs.reprovider != nil {
err = multierror.Append(err, bs.reprovider.Close())
}
err = multierror.Append(err, bs.blockService.Close())

if err.ErrorOrNil() != nil {
Expand All @@ -197,6 +204,9 @@ func NewBlobService(
}

func (bs *blobService) TriggerReprovide(ctx context.Context) error {
if bs.reprovider == nil {
return nil
}
return bs.reprovider.Reprovide(ctx)
}

Expand Down
Loading