[v0.48] Enforce global stream limit per WebSocket subscription#8537
[v0.48] Enforce global stream limit per WebSocket subscription#8537peterargue wants to merge 1 commit intov0.48from
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Backport of #8536 to v0.48.
Summary
/wsendpoint multiplexes many subscriptions over a single connection, so the previous connection-level enforcement was incorrect: one connection could bypassMaxGlobalStreams, while idle connections consumed the budgetAcquire()/Release()methods toConcurrencyLimiterfor lifecycle-scoped slot managementhandleSubscribeTest plan
ConcurrencyLimitertests forAcquire/Release(within limit, at limit, concurrent)