fix(cloudflare): retry catalog load after failure

[cyphercodes]

Summary

• clear rejected Cloudflare app and catalog promises so a recovered asset binding is retried
• evict only the promise that is still cached, preserving concurrent request deduplication
• cover concurrent failure sharing and a successful retry through worker.fetch

Fixes #246

Validation

• npx vitest run src/server/cloudflare.test.ts (5 tests)
• npm run fix-check
• npm test (66 files, 704 tests)
• npm run lint
• npm run format
• git diff --check

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a6160a28-3c2f-4407-ad8b-43793754a5ce

📥 Commits

Reviewing files that changed from the base of the PR and between a4b5c30 and ba3b600.

📒 Files selected for processing (4)

• src/server/cloudflare.test.ts
• src/server/cloudflare.ts
• src/server/cloudflare/isolate-promise-cache.test.ts
• src/server/cloudflare/isolate-promise-cache.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• src/server/cloudflare.test.ts

---

Summary by CodeRabbit

• Bug Fixes
  • Improved app initialization reliability during concurrent requests.
  • Prevented duplicate catalog requests while initialization is in progress.
  • Failed catalog loads can now be retried successfully instead of leaving the app in a failed state.
  • Improved reliability when loading application configuration and security-related settings concurrently.
  • Ensured newer initialization attempts are not affected by failures from earlier attempts.

Walkthrough

Cloudflare initialization now uses IsolatePromiseCache for app, catalog, and secret-codec promises. Same-key concurrent requests share initialization work. Rejected promises are evicted only when they still own the cache entry. A later request can retry after a transient catalog failure. Tests cover cache reuse, key replacement, rejection handling, and concurrent Cloudflare requests.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title follows the required format and clearly describes the Cloudflare catalog retry fix.
Description check	✅ Passed	The description explains the rejection handling, concurrency behavior, regression coverage, and validation for the Cloudflare changes.
Linked Issues check	✅ Passed	The changes clear rejected catalog and app promises, preserve concurrent deduplication, and add regression coverage for failure followed by retry [#246].
Out of Scope Changes check	✅ Passed	The cache abstraction and related secret-codec handling support the same rejection-retry behavior and remain consistent with the pull request objectives.

✨ Finishing Touches

✨ Simplify code

• Create PR with simplified code

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/server/cloudflare.test.ts`:
- Around line 28-63: Reset the module-scoped catalogPromise before each test so
the concurrent app-creation test always initializes its catalog from the
supplied env.ASSETS binding. Add a beforeEach reset in the test setup or use an
existing catalog-cache reset hook, preserving the retry assertions and avoiding
reuse of a resolved cache from earlier tests.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c159e20a-1c57-4a7e-8c64-ea042e4c6902

📥 Commits

Reviewing files that changed from the base of the PR and between deadc1c and 6751cda.

📒 Files selected for processing (2)

• src/server/cloudflare.test.ts
• src/server/cloudflare.ts